feat: vm.blobhashes
#7001
Merged
feat: vm.blobhashes
#7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2024
DaniPopes
requested changes
Feb 2, 2024
Evalir
approved these changes
Feb 2, 2024
|
Gonna take a while, I have to redo the entire testdata directory since we want to run Cancun separate from every other test, and currently we just compile everything in the |
|
Is this pr currently blocked? |
|
yes, but not on a feature/pr, just on time. we need to restructure most of our testing suite because we want to test cancun separately |
|
@yash-atreya this should be unblocked now with cancun specific test setup so ptal |
|
@mattsse ptal |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is no way to mock blobhashes currently
Solution
Add a cheatcode to set all blobhashes in the transaction. Note that this takes a list of blobhashes, as setting them individually by index would require us to fill the blobhash list with garbage in some cases to grow the list to an appropriate size and avoid a panic.
Closes #6996