test: add more positive fuzz test cases #7101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 13, 2024
mattsse
reviewed
Feb 13, 2024
what do you think I should do |
|
do you think the failure here might be to race conditons |
mattsse
requested changes
Feb 20, 2024
There was a problem hiding this comment.
the issue here is that these functions are being run in another test:
--- TRY 3 STDERR: forge::it fuzz::test_fuzz ---
thread 'fuzz::test_fuzz' panicked at crates\forge\tests\it\fuzz.rs:37:22:
Test testSuccessChecker(uint256) did not fail as expected.
Reason: None
Logs:
I think the best solution here would be to move the new tests to a new contract/file
|
ok |
onbjerg
approved these changes
Feb 22, 2024
|
I think I've fixed it |
onbjerg
requested changes
Feb 26, 2024
Co-authored-by: Oliver Nordbjerg <[email protected]>
zeroXbrock
pushed a commit
to flashbots/suavex-foundry
that referenced
this pull request
Apr 2, 2024
* changes * changes * proposed fix * format * fixed * Update crates/forge/tests/it/fuzz.rs Co-authored-by: Oliver Nordbjerg <[email protected]> --------- Co-authored-by: Oliver Nordbjerg <[email protected]>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #971