refactor: local trace decoder and identifier #7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
Feb 13, 2024
|
|
||
| if max_len == 0 { | ||
| // Skip checking individual bytes if the lengths are too different. | ||
| if n_different_bytes > 32 && n_different_bytes * 10 > a.len() { |
There was a problem hiding this comment.
would pref if we moved the constants out and named them to make it clearer why we chose these numbers
DaniPopes
force-pushed
the
dani/trace-decoder
branch
from
9c8678a
to
0e1a711
Compare
klkvr
approved these changes
Feb 14, 2024
DaniPopes
force-pushed
the
dani/trace-decoder
branch
from
69ba162
to
ae2e165
Compare
2 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #7091
cc @mds1 @klkvr