Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cast): abi-encode-packed #7150

Merged
merged 1 commit into from
Feb 17, 2024
Merged

feat(cast): abi-encode-packed #7150

merged 1 commit into from
Feb 17, 2024

Conversation

bernard-wagner
Copy link
Contributor

Blocked by #7149

Motivation

Useful to calculate abi.encodePacked without chisel.

Solution

Update alloy-dyn-abi to make use of fixed abi_encode_packed alloy-rs/core#517

@bernard-wagner bernard-wagner changed the title Abi encode packed WIP: Abi encode packed Feb 16, 2024
@bernard-wagner bernard-wagner marked this pull request as draft February 16, 2024 07:51
@bernard-wagner bernard-wagner changed the title WIP: Abi encode packed Abi encode packed Feb 16, 2024
@bernard-wagner bernard-wagner marked this pull request as ready for review February 16, 2024 09:46
@bernard-wagner bernard-wagner changed the title Abi encode packed feat(cast): abi-encode-packed @bernard-wagner Feb 16, 2024
@bernard-wagner bernard-wagner changed the title feat(cast): abi-encode-packed @bernard-wagner feat(cast): abi-encode-packed Feb 16, 2024
DaniPopes
DaniPopes approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 9e24233 into foundry-rs:master Feb 17, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernard-wagner @DaniPopes