fix(providers): remove locks on requests

[klkvr]

Motivation

Closes #7131

We are basically blocking all async requests through provider rn by aquiring write lock before making a request.

Solution

Use read lock

[mattsse]

nit

[mattsse]

we're acquiring this twice now we could do the this combined in an if let else

by checking this.inner.read().await.cloned()

also the write check still has a race condition, so we also need to check for is_none there again

[DaniPopes]

I don't think we even need to clone since Service is implemented for &Http and &Pubsub

[klkvr]

ah right, it works as long as we can obtain &mut &T

match this.inner.read().await.as_ref().unwrap() {
    InnerTransport::Http(http) => {
        let mut http = http;
        http.call(req)
    },
}

is there a cleaner way to do this without that strange let?

[DaniPopes]

Don't think so

[klkvr]

refactored it, now we don't clone and check second time after aquiring write lock

we can't use if let some there anymore I believe because we don't clone

[gakonst]

can do InnerTransport::Http(mut http)?

[DaniPopes]

can do InnerTransport::Http(mut http)?

mut http removes the reference

error[E0507]: cannot move out of a shared reference
   --> crates/common/src/provider/runtime_transport.rs:228:19
    |
228 |             match inner.as_ref().expect("must've been initialized") {
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
229 |                 InnerTransport::Http(mut http) => http.call(req),
    |                                      --------
    |                                      |
    |                                      data moved here
    |                                      move occurs because `http` has type `alloy_transport_http::Http<reqwest::Client>`, which does not implement the `Copy` trait
    |
help: consider borrowing the pattern binding
    |
229 |                 InnerTransport::Http(ref mut http) => http.call(req),
    |                                      +++

And ref mut creates &mut T when we want &mut &T. This looks like a weird case that's not covered by patterns ig

[Evalir]

Amazing catch