fix(invariants): support vm.assume in invariant tests
#7309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
changed the title
vm.assume in invariant tests
DaniPopes
reviewed
Mar 5, 2024
DaniPopes
approved these changes
Mar 5, 2024
2 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4190
Solution
Catch reverts with
MAGIC_ASSUME, regenerate latest calldata and increaseassume_rejects_counter. Once counter goes beyond configuredmax_assume_rejects, test fails.I've changed
InvariantFuzzErrorto be an enum, because we don't need data it holds right now forMaxAssumeRejectsfailures.Also changed
invariant_strata bit, currently it always returns Vec with one element, it seemed a bit confusing at first glance, so I changed it to return just a single input.