feat: parse inline config with solang #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Mar 18, 2024
|
with a3b20da this has virtually no perf impact even on huge repos |
klkvr
approved these changes
Mar 18, 2024
| // id.identifier | ||
| let abs_path = id.source.as_path(); | ||
| let path = abs_path.strip_prefix(root).unwrap_or(abs_path); | ||
| // `id.identifier` but with the stripped path. | ||
| let contract = format!("{}:{}", path.display(), id.name); |
There was a problem hiding this comment.
id.name can be in the form of "Counter.0.8.23", I am doing id.name.split('.').next().unwrap() usually, we should probably have a helper for this in compilers
Yes |
beskay
added a commit
to ethernautdao/evm-runners-cli
that referenced
this pull request
Mar 19, 2024
Does inline config not work at all with inheritance, or it just doesn't properly override it? For either answer we should just document any limitations in the book https://book.getfoundry.sh/reference/config/inline-test-config#in-line-invariant-configs |
sveitser
added a commit
to EspressoSystems/espresso-sequencer
that referenced
this pull request
Apr 23, 2024
- Update flake.lock to get a foundry bugfix that enables fixes inline config: foundry-rs/foundry#7431 - Only set `RAYON_NUM_THREADS` in prover. Foundry also uses it to set how many tests run in parallel. In addition it sets parallelism for `diff-test` which is run by foundry tests.
sveitser
added a commit
to EspressoSystems/espresso-sequencer
that referenced
this pull request
Apr 23, 2024
- Update flake.lock to get a foundry bugfix that enables fixes inline config: foundry-rs/foundry#7431 - Only set `RAYON_NUM_THREADS` in prover. Foundry also uses it to set how many tests run in parallel. In addition it sets parallelism for `diff-test` which is run by foundry tests.
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7310