[#4628] Replace roll parts rather than rebuilding config entirely #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove an issue with programmatically altering roll config for skill/tool checks & attack rolls, this modifies the `buildConfig` method to swap part data in-place, rather than completely rebuild the parts & data objects. To do this easily this introduces `BasicRoll#swapParts` which is designed to swap part data and part keys in place without losing the original ordering of the parts. Closes #4628
arbron
added
bug
Fyorl
reviewed
Nov 11, 2024
There was a problem hiding this comment.
This might be the only solution but I'd like to try to keep our auto-computed and arbitrarily added parts separate so that they can always be re-computed from scratch, rather than merging parts eagerly and then having to swap them in-place. I feel like if we could incorporate the initialRoll concept into this framework then we'd be even better off than when we started.
I think this needs a bit more thought, so we might have to pull this PR from the milestone for now so that it doesn't hold up the rest of the other fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove an issue with programmatically altering roll config for skill/tool checks & attack rolls, this modifies the
buildConfigmethod to swap part data in-place, rather than completely rebuild the parts & data objects. To do this easily this introducesBasicRoll#swapPartswhich is designed to swap part data and part keys in place without losing the original ordering of the parts.Todo
Closes #4628