[FIX] progressRegex #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing quantifier to progressRegex
christo
reviewed
Jan 25, 2024
| @@ -18,7 +18,7 @@ import { stdout } from 'process'; | |||
|
|
|||
| const executableName = 'yt-dlp'; | |||
| const progressRegex = | |||
| /\[download\] *(.*) of ([^ ]*)(:? *at *([^ ]*))?(:? *ETA *([^ ]*))?/; | |||
| /\[download\] *(.*) of *([^ ]*)(:? *at *([^ ]*))?(:? *ETA *([^ ]*))?/; | |||
There was a problem hiding this comment.
If I'm reading this regex correctly, the space before the new * is being quantified which suggests that there may be no space in the yt-dlp output between the "of" and the following non-space part. I haven't confirmed this but I'm surprised there would ever be no space.
If your change is supposed to handle 1 or more spaces, + is the correct quantifier.
|
Thanks for making this fix, I have had this same problem of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing 'zero or more'
*quantifier to progressRegex that fixes not reporting the progress correctly.Before:
{"percent":66.3,"totalSize":""}After:
{"percent":45.6,"totalSize":"21.41MiB","currentSpeed":"5.83MiB/s","eta":"00:02"}Thank you for maintaining this node module.