Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iterator not iterating over all chunks #75

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Mar 5, 2024

Public-Facing Changes

Fix iterator not iterating over all chunks

Description

Supersedes #72

image
In my scenario, starting from {sec: 0, nsec: 0}, when reading topic=['A ',' B '], we first read A1, B1, A2, and then position is at position Other (red line). After the heap is consumed, we call LoadNext (to read chunkB, chunkC) and cannot read the data. We then perform an additional loadNext, but still cannot read the data at chunkC, and then exit. We lost the data for A3.

Copy link

linear bot commented Mar 5, 2024

@achim-k achim-k merged commit f7c852b into main Mar 5, 2024
2 checks passed
@achim-k achim-k deleted the achim/fg-6304-fix-iterator-chunks branch March 5, 2024 14:34
@achim-k achim-k mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants