Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all properties should be marked with a tick timestamp #255

Closed
TheYellowArchitect opened this issue Aug 27, 2024 · 0 comments
Closed

all properties should be marked with a tick timestamp #255

TheYellowArchitect opened this issue Aug 27, 2024 · 0 comments

Comments

@TheYellowArchitect
Copy link
Contributor

TheYellowArchitect commented Aug 27, 2024

This helps immensely with implementing (and debugging) diff state, and input delay #261

However, if each property entry added a tick_timestamp: int variable added to it, it would be bloated, because 5 properties would have 5 tick timestamps, all of these tick timestamps being the exact same value!

So I suggest having something like a wrapper, like so:

PropertiesWrapper
var tick_timestamp: int
var properties: Array[PropertyEntry]

and it is the above class used for states and inputs.

My suggestion is to simply hardcode a property onto each Array[PropertyEntry], that being ["tick"], see #261

Edit: nvm I'm stupid. I just used the tick index before the properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant