Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/websocket #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

csgpwi
Copy link

@csgpwi csgpwi commented Jul 21, 2023

Add support for jenkins websockets and python3 to slave.py

@foxylion
Copy link
Owner

Hi @csgpwi, did you test your changes?
Since when do the paths have changed in Jenkins?
Will this break existing users of the image?

@pjwiseman
Copy link

@foxylion

  1. I ran adhoc tests of the slave.py changes against python2 and python3, in a fresh venv, and with/without the SLAVE_WEBSOCKET env to test backward compatibility.
  2. Slave terminology was deprecated in Jenkins 2.0. See https://issues.jenkins.io/browse/JENKINS-42816 for the main epic. The slave-agent to jenkins-agent change was released 2.264 (2020-10-27). I made the change out of concern that the old name would eventually be removed.
  3. The slave terminology change will break existing implementations running a jenkins version prior to 2.264. I'm happy to revert that part of the change if you think it best. I don't have the capacity to implement support for both old and new names during the transition period until jenkins remove support for the old naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants