Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raise a warn when using direct file device on a file system #715

Closed
MrCroxx opened this issue Sep 17, 2024 · 0 comments · Fixed by #730
Closed

feat: raise a warn when using direct file device on a file system #715

MrCroxx opened this issue Sep 17, 2024 · 0 comments · Fixed by #730
Assignees
@MrCroxx
Labels
feature New feature or request good first issue Good for newcomers
Milestone
v0.11

Comments

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 17, 2024

DirectFileDevice should be used to overcome the overhead of the file system directly on the raw device. Raise a warn when using it on a file system because it will make the overhead even worse.
@MrCroxx MrCroxx added the feature New feature or request label Sep 17, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 17, 2024
@MrCroxx MrCroxx self-assigned this Sep 17, 2024
@MrCroxx MrCroxx added the good first issue Good for newcomers label Sep 20, 2024
@MrCroxx MrCroxx mentioned this issue Sep 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrCroxx MrCroxx

Labels
feature New feature or request good first issue Good for newcomers
Projects
foyer - Development Roadmap
Status: Done
Milestone
v0.11
Development

Successfully merging a pull request may close this issue.

chore: warn if DirectFileDevice is used in a fs foyer-rs/foyer
1 participant
@MrCroxx