Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn if DirectFileDevice is used in a fs #730

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: warn if DirectFileDevice is used in a fs #730

merged 1 commit into from
Sep 20, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 20, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #715

@MrCroxx MrCroxx added the feature New feature or request label Sep 20, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 20, 2024
@MrCroxx MrCroxx self-assigned this Sep 20, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) September 20, 2024 07:56
@MrCroxx MrCroxx merged commit 553a9cb into main Sep 20, 2024
19 checks passed
@MrCroxx MrCroxx deleted the xx/warn branch September 20, 2024 07:59
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/device/direct_file.rs 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/device/direct_file.rs 85.08% <50.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: raise a warn when using direct file device on a file system
1 participant