Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add chroma to the showcase #617

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: add chroma to the showcase #617

merged 1 commit into from
Jul 18, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 17, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

After chroma-core/chroma#2431 is merged, Chroma is a foyer user now. 🥰

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added the chore label Jul 17, 2024
@MrCroxx MrCroxx self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (8f40c19) to head (66fb485).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   81.66%   81.70%   +0.04%     
==========================================
  Files          66       66              
  Lines        8425     8425              
==========================================
+ Hits         6880     6884       +4     
+ Misses       1545     1541       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammadB
Copy link

HammadB commented Jul 17, 2024

<3

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Jul 17, 2024

Hi, @HammadB . Nice to see you here. Is it okay that I put the link to Chroma here?

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Jul 18, 2024

https://discord.com/channels/1073293645303795742/1262974035537690736/1263217009458675822

Got response in discord channel. Go for it. 🥵

@MrCroxx MrCroxx marked this pull request as ready for review July 18, 2024 03:01
@MrCroxx MrCroxx merged commit c76badb into main Jul 18, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/sc branch July 18, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants