Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning when region count is smaller than expected #784

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Oct 31, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added the chore label Oct 31, 2024
@MrCroxx MrCroxx added this to the v0.12 milestone Oct 31, 2024
@MrCroxx MrCroxx self-assigned this Oct 31, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) October 31, 2024 06:14
@MrCroxx MrCroxx merged commit 2e4844b into main Oct 31, 2024
20 checks passed
@MrCroxx MrCroxx deleted the xx/warn branch October 31, 2024 06:25
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/large/generic.rs 33.33% 4 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/large/generic.rs 88.82% <33.33%> (-0.93%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant