fix: identification of duplicate @returns (cppalliance#638)

fpelliccioni · Jul 3, 2024 · 057778c · 057778c
1 parent bb7d201
commit 057778c
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/lib/AST/ParseJavadoc.cpp b/src/lib/AST/ParseJavadoc.cpp
@@ -954,22 +954,21 @@ visitBlockCommandComment(
     case CommandTraits::KCI_returns:
     case CommandTraits::KCI_result:
     {
-        doc::Returns returns;
-        auto scope = enterScope(returns);
-        // Scope scope(returns, block_);
-        visitChildren(C->getParagraph());
-
         auto itr = std::ranges::find_if(
             jd_.getBlocks(),
             [&](const std::unique_ptr<doc::Block> & b)
         {
-            return b->kind != doc::Kind::returns;
+            return b->kind == doc::Kind::returns;
         });
         if (itr != jd_.getBlocks().end())
         {
             report::warn("{}: Duplicate @returns statement", C->getBeginLoc().printToString(sm_));
         }
 
+        doc::Returns returns;
+        auto scope = enterScope(returns);
+        // Scope scope(returns, block_);
+        visitChildren(C->getParagraph());
         jd_.emplace_back(std::move(returns));
         return;
     }