Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompts for branch name, Python version, and test OS selection #129

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

synacktraa
Copy link

@synacktraa synacktraa commented Oct 3, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If there is a related issue, make sure it is linked to this PR.
  • Documentation in docs is updated

Description of changes

  • Branch name prompt (My default repository branch is master, so a prompt would be really helpful).
  • Minor python version prompt so the user can decide the version matrix to use. It applies to .github, tox.ini and pyproject.toml. Selected minor version is applied to Dockerfile.
  • test_on_{os} prompts so the user can decide the os matrix to use. Defaults to ubuntu-latest. I would like to make these prompts dependent on include_github_actions but cookiecutter still hasn't merged the conditional prompt feature.
  • Pytest coverage is not ran if codecov is disabled. Solves this issue: Pytest still tries to run coverage when codecov is not enabled #128

@fpgmaas
Copy link
Owner

fpgmaas commented Oct 8, 2024

@synacktraa Thanks for your suggestions! Some feedback;

  • Providing the option for a minor python version; yes, let's add that. Maybe rename it to main python version instead?
  • branch name prompt; I think main is the defacto standard today, so I don't think we should provide the option for a main branch name.
  • test on multiple OS's. I think this could be useful. However, I'd prefer to see it in a separate PR so it's easier to review in depth. Is that possible?
  • pytest coverage fix, obviously good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants