feat(pdm): handle PEP 621 dev groups

fpgmaas · Mar 23, 2024 · 437b043 · 437b043
1 parent 545c2b3
commit 437b043
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 14 deletions.
diff --git a/python/deptry/core.py b/python/deptry/core.py
@@ -144,7 +144,9 @@ def _get_dependencies(self, dependency_management_format: DependencyManagementFo
         if dependency_management_format is DependencyManagementFormat.POETRY:
             return PoetryDependencyGetter(self.config, self.package_module_name_map).get()
         if dependency_management_format is DependencyManagementFormat.PDM:
-            return PDMDependencyGetter(self.config, self.package_module_name_map).get()
+            return PDMDependencyGetter(
+                self.config, self.package_module_name_map, self.pep621_dev_dependency_groups
+            ).get()
         if dependency_management_format is DependencyManagementFormat.PEP_621:
             return PEP621DependencyGetter(
                 self.config, self.package_module_name_map, self.pep621_dev_dependency_groups

diff --git a/python/deptry/dependency_getter/pdm.py b/python/deptry/dependency_getter/pdm.py
@@ -21,7 +21,10 @@ class PDMDependencyGetter(PEP621DependencyGetter):
     def get(self) -> DependenciesExtract:
         pep_621_dependencies_extract = super().get()
 
-        return DependenciesExtract(pep_621_dependencies_extract.dependencies, self._get_pdm_dev_dependencies())
+        return DependenciesExtract(
+            pep_621_dependencies_extract.dependencies,
+            [*pep_621_dependencies_extract.dev_dependencies, *self._get_pdm_dev_dependencies()],
+        )
 
     def _get_pdm_dev_dependencies(self) -> list[Dependency]:
         """

diff --git a/tests/data/project_with_pdm/pyproject.toml b/tests/data/project_with_pdm/pyproject.toml
@@ -28,5 +28,8 @@ test = [
     "pytest-cov>=4.0.0",
 ]
 
+[tool.deptry]
+pep621_dev_dependency_groups = ["bar"]
+
 [tool.deptry.per_rule_ignores]
 DEP002 = ["pkginfo"]
diff --git a/tests/functional/cli/test_cli_pdm.py b/tests/functional/cli/test_cli_pdm.py
@@ -33,18 +33,6 @@ def test_cli_with_pdm(pdm_venv_factory: PDMVenvFactory) -> None:
                     "column": None,
                 },
             },
-            {
-                "error": {
-                    "code": "DEP002",
-                    "message": "'requests' defined as a dependency but not used in the codebase",
-                },
-                "module": "requests",
-                "location": {
-                    "file": str(Path("pyproject.toml")),
-                    "line": None,
-                    "column": None,
-                },
-            },
             {
                 "error": {
                     "code": "DEP004",