Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect file encoding with chardet before parsing the .py file #103

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Sep 14, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@fpgmaas fpgmaas linked an issue Sep 14, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #103 (a73602b) into main (d9aef9c) will decrease coverage by 1.9%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #103     +/-   ##
=======================================
- Coverage   94.6%   92.6%   -2.0%     
=======================================
  Files         30      30             
  Lines       1097    1120     +23     
=======================================
  Hits        1038    1038             
- Misses        59      82     +23     
Impacted Files Coverage Δ
deptry/import_parser.py 73.7% <100.0%> (-22.3%) ⬇️
tests/test_import_parser.py 89.7% <100.0%> (-10.3%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas merged commit 4a90ae1 into main Sep 14, 2022
@fpgmaas fpgmaas deleted the 102-unicode-decode-error branch September 14, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternate file encodings throw UnicodeDecodeError
2 participants