Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed parsing logic; only try to get encoding if initial parsing fails #105

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Sep 15, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@codecov-commenter
Copy link

Codecov Report

Merging #105 (567a435) into main (004d780) will decrease coverage by 0.2%.
The diff coverage is 83.3%.

@@           Coverage Diff           @@
##            main    #105     +/-   ##
=======================================
- Coverage   94.7%   94.5%   -0.3%     
=======================================
  Files         30      30             
  Lines       1120    1132     +12     
=======================================
+ Hits        1061    1070      +9     
- Misses        59      62      +3     
Impacted Files Coverage Δ
deptry/import_parser.py 93.4% <81.2%> (-2.8%) ⬇️
tests/test_import_parser.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas merged commit bc0c967 into main Sep 15, 2022
@fpgmaas fpgmaas deleted the 102-encodings-2 branch September 15, 2022 06:27
@fpgmaas
Copy link
Owner Author

fpgmaas commented Sep 15, 2022

#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants