Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install_requires to setup.py/setup.cfg, or add pyproject.toml #185

Closed
mkoeppe opened this issue Nov 14, 2020 · 3 comments · Fixed by #192
Closed

Add install_requires to setup.py/setup.cfg, or add pyproject.toml #185

mkoeppe opened this issue Nov 14, 2020 · 3 comments · Fixed by #192

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 14, 2020

On a system with fplll installed, pip install fpylll fails because the distribution does not declare its Python build dependencies.

malb added a commit that referenced this issue Nov 20, 2020
@malb
Copy link
Collaborator

malb commented Nov 20, 2020

We're using distutils which doesn't know install_requires and I dread adding more of these meta files to the toplevel directory of the project. I'm inclined to close this as wontfix. How big of an issue is it?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

How big of an issue is it?

It's critical because it makes it impossible for another Python project to declare a dependency on fpylll.

@malb
Copy link
Collaborator

malb commented Nov 21, 2020

Okay, the PR referenced above should do what is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants