Update nlohmann/json submodule to v3.11.3. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update to the json library resolves some deprecation warnings that were treated as errors in the Apple clang build, and had been worked-around with a temporary setting in the CMake configuration.
|
Glad that it's resolved, thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to the json library resolves some deprecation warnings that were treated as errors in the Apple clang build, and had been worked-around with a temporary setting in the CMake configuration.
Merging this change will require 'git submodule update' and then a forced rebuild of the 3rd party dependencies (or a removal of build-third/include/nlohmann followed by an incremental build).
This PR addresses #181 which can now be closed.