Multidimensional reorder #1862
Multidimensional reorder #1862
Conversation
* add multidimensional sorting * fix tests * refactor naming * add TODO * remove items per axis * add new observer * add max-height to column sort * remove unused comments * add observer disconnection * add observer disconnection * add external ref * fix error if there is only one item Co-authored-by: Christian Jöcker <[email protected]> Co-authored-by: Matt Perry <[email protected]>
| ) | ||
|
|
||
| if (itemLayout![crossAxis].min > prevItemLayout![crossAxis].min) { | ||
| itemsPerAxis = i // Should this not be + 1? |
There was a problem hiding this comment.
[ 0 ] [ 1 ] [ 2 ]
[ 3 ]
Since the iteration starts on one, but looks back for 0, I think this is accurate as itemsPerAxis = i, because the value should be 3 in this example right? (0, 1, 2)
|
Hi there! |
|
echoing the previous comment, any update here? |
|
@mattgperry Hey! Are there any plans to merge this PR any time soon? |
|
Hey all, Matt is on paternity leave and will be able to consider this when he's back in a few weeks time! 😊 |
|
Congratulations @mattgperry 😄 ! Thanks for letting us know @Hemlok ! |
|
Hello guys, do we have any update on this? that would be really nice to have this feature production ready 😃 |
|
Looks great, hoping to see this soon! |
|
@42arch hi do we have any plan to merge this PR or will take long ? |
|
This is really needed |
|
Waiting for this! |
|
Bump! This would be awesome |
|
Waiting for this! Really needed |
|
Excited for this feature, should we expect this soon? |
|
Can't wait for it! Really need it. |
|
Any updates on this? Would be very helpful. |
|
any updates? |
|
MERGE THIS SOON!!! |
|
Merge this ASAP please! |
|
I posted here nearly 3 months ago and ended up just using dnd-kit which I would really recommend - especially if you're not already tied to framer |
|
let's merge! |
|
any plans on this getting merged? |
|
Hi, any update on this, I need multi reorder in my project |
|
As an update I made this PR as an attempt to brush it up and rebase it to latest but honestly it just didn't work well enough to merge, it's quite buggy and feels off. I had a quick attempt at polishing it up but to no avail - I am closing for now because I know I won't get to it any time soon. I like the idea in general so I would accept a revival PR that implements both multidimensional reordering and also the auto-axis detection. But it would have to actually feel good and work well. There's an example file |
This PR adds multidimensional reordering to
Reordercomponents.Continuation of #1685
Fixes #1400