fix: trim query strings of lichess game URL #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It still doesn't work with those links because the gameID is not in the 4th position |
|
Modified to retrieve the last path of URL |
|
The link can also have /white or /black at the end depending on the orientation. The best solution is probably with some regex. |
| @@ -119,7 +119,7 @@ export default function ImportModal({ | |||
| if (link.includes("chess.com")) { | |||
| pgn = await getChesscomGame(link); | |||
| } else if (link.includes("lichess")) { | |||
| const gameId = link.split("/")[3]; | |||
| const gameId = link.split("?")[0].split("/").pop() || ""; | |||
There was a problem hiding this comment.
Here is a cleaner way to do this:
Suggested change
| const gameId = link.split("?")[0].split("/").pop() || ""; | |
| const excludedPathParts = ['game', 'export', 'white', 'black']; | |
| const gameId = new URL(link).pathname.split('/').find(x => x && !excludedPathParts.includes(x)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR trims the query strings of the lichess game URL so that PGN URLs can also be imported instead of regular URLs.
(General URL: blue square, PGN URL: red square)