Skip to content

Commit

Permalink
fix: Fix field mapping logic during feature inference (feast-dev#3067)
Browse files Browse the repository at this point in the history
fix: Fix bug where feature inference was improperly registering timestamp and created field if part of field_mapping

Signed-off-by: Miles Adkins <[email protected]>

Signed-off-by: Miles Adkins <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
  • Loading branch information
sfc-gh-madkins authored and franciscojavierarceo committed Aug 13, 2022
1 parent 14d501d commit 14a9ce9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/python/feast/inference.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ def _infer_features_and_entities(
fv.batch_source.timestamp_field,
fv.batch_source.created_timestamp_column,
}
for column in columns_to_exclude:
if column in fv.batch_source.field_mapping:
columns_to_exclude.remove(column)
columns_to_exclude.add(fv.batch_source.field_mapping[column])
for original_col, mapped_col in fv.batch_source.field_mapping.items():
if mapped_col in columns_to_exclude:
columns_to_exclude.remove(mapped_col)
columns_to_exclude.add(original_col)

table_column_names_and_types = fv.batch_source.get_table_column_names_and_types(
config
Expand Down

0 comments on commit 14a9ce9

Please sign in to comment.