This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
feat(onSubmit): introduce onSubmit option
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +46,16 @@ export function getPropGetters<TItem>({ | |||
| onSubmit: event => { | |||
| event.preventDefault(); | |||
There was a problem hiding this comment.
I'm wondering if preventing the default behavior should be part of the default onSubmit implementation. Are there any cases where users would like to use the default submit form event?
There was a problem hiding this comment.
I don't see any use case where user would want to keep default submit event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
onSubmitoption. This prop is called when thesubmitform event is triggered (not when an item is selected – subject to another PR).Use case
The
submitform event is triggered when the user hits Enter without any item selected.In an InstantSearch context, it's the default behavior of the search box, where we would call
refine. Note that with an InstantSearch implementation, we would also callrefinewhen callingonSelect.