Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: __DEV__ build conflict (fix #221) #222

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

briangleeson
Copy link
Contributor

Issue: #221

Using __DEV__ in a few places causes error during production build if another package also uses that variable name, as the build replaces __DEV__ with false in the other package. Renaming the variable used in vite-ssr avoids this conflict

For example, see this error:

[commonjs--resolver] Unexpected keyword 'false' (55:5) in C:/Snaps/pwp/pwp-ui/node_modules/@carbon/react/es/components/ModalWrapper/ModalWrapper.js
file: node_modules/@carbon/react/es/components/ModalWrapper/ModalWrapper.js:55:5
55:   if(false) {

Using __DEV__ in a few places causes error during build if another
package also uses that variable name, as the build replaces __DEV__
with false in the other package
@briangleeson briangleeson changed the title fix: __DEV__ build conflict (fix #221[,#221]) fix: __DEV__ build conflict (fix #221) Jul 24, 2024
@briangleeson
Copy link
Contributor Author

@frandiox would it be possible to get this reviewed? We're eager to get this issue fixed and available in a new release of vite-ssr

@briangleeson
Copy link
Contributor Author

@m3hari you appear to have merged changes in this repo in the past, would you be able to review this PR? There's no sign of @frandiox

@frandiox
Copy link
Owner

frandiox commented Aug 7, 2024

Hey @briangleeson ! Sorry I've out of town for a while 😓 -- I'll try to merge this and release but will probably need to be next week.

@briangleeson
Copy link
Contributor Author

Ok, that'd be great 👍

@frandiox frandiox merged commit 63498e2 into frandiox:master Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants