Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid exchange loss booking on invoice against base accounts #40511

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Mar 18, 2024

Fix issue where Exchange Gain/Loss was incorrect calculated while reconciling Invoices that post to company currency receivable account.

regression: #40149

todo:

  • test case

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 18, 2024
@ruthra-kumar ruthra-kumar changed the title fix: invalid exchange loss booking on invoice againts base accounts fix: invalid exchange loss booking on invoice against base accounts Mar 18, 2024
@ruthra-kumar ruthra-kumar linked an issue Mar 18, 2024 that may be closed by this pull request
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Mar 18, 2024
@ruthra-kumar ruthra-kumar merged commit 3dd6686 into frappe:develop Mar 18, 2024
14 checks passed
ruthra-kumar added a commit that referenced this pull request Mar 18, 2024
…-40511

fix: invalid exchange loss booking on invoice against base accounts (backport #40511)
ruthra-kumar added a commit that referenced this pull request Mar 18, 2024
…-40511

fix: invalid exchange loss booking on invoice against base accounts (backport #40511)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Entry : Exchange Gain or Loss
1 participant