fix: incorrect IFSC codes in bank remittance report (backport #1538) (#…

…1583) * fix: faulty ifsc codes in bank remittance report * refactor(payroll): bank remittance report * refactor: format bank_remittance.py (cherry picked from commit 2b3904a) Co-authored-by: Viny Selopal <[email protected]>
frappe · Mar 26, 2024 · 2c08519 · 2c08519
1 parent 92331aa
commit 2c08519
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/hrms/payroll/report/bank_remittance/bank_remittance.py b/hrms/payroll/report/bank_remittance/bank_remittance.py
@@ -22,7 +22,12 @@ def execute(filters=None):
 			"hidden": 1,
 			"width": 200,
 		},
-		{"label": _("Payment Date"), "fieldtype": "Data", "fieldname": "payment_date", "width": 100},
+		{
+			"label": _("Payment Date"),
+			"fieldtype": "Data",
+			"fieldname": "payment_date",
+			"width": 100,
+		},
 		{
 			"label": _("Employee Name"),
 			"fieldtype": "Link",
@@ -146,12 +151,10 @@ def get_emp_bank_ifsc_code(salary_slips):
 	emp_names = [d.employee for d in salary_slips]
 	ifsc_codes = get_all("Employee", [("name", "IN", emp_names)], ["ifsc_code", "name"])
 
-	ifsc_codes_map = {}
-	for code in ifsc_codes:
-		ifsc_codes_map[code.name] = code
+	ifsc_codes_map = {code.name: code.ifsc_code for code in ifsc_codes}
 
 	for slip in salary_slips:
-		slip["ifsc_code"] = ifsc_codes_map[code.name]["ifsc_code"]
+		slip["ifsc_code"] = ifsc_codes_map[slip.employee]
 
 	return salary_slips