fix: naming

(cherry picked from commit 981a017)

hrms/hr/doctype/goal/goal.py

@@ -208,7 +208,7 @@ def update_progress(progress: float, goal: str) -> None:
 
 @frappe.whitelist()
 def update_status(status: str, goals: str | list) -> None:
-	if type(goals) is not list:
+	if isinstance(goals, str):
 		import json
 
 		goals = json.loads(goals)

hrms/hr/doctype/goal/goal_list.js

@@ -55,7 +55,7 @@ frappe.listview_settings["Goal"] = {
 			.filter(
 				(item) =>
 					!item.is_group &&
-					applicable_current_statuses(status).includes(item.status)
+					get_applicable_current_statuses(status).includes(item.status)
 			)
 			.map((item) => item.name);
 		if (!items_to_be_updated.length)
@@ -70,25 +70,26 @@ frappe.listview_settings["Goal"] = {
 				__("{0} {1} {2}?", [
 					simple_present_tense[status],
 					items_to_be_updated.length.toString(),
-					items_to_be_updated.length === 1 ? "item" : "items",
+					items_to_be_updated.length === 1 ? __("goal") : __("goals"),
 				]),
 				() => {
 					this.update_status("", items_to_be_updated, listview);
 					this.trigger_error_dialogs(checked_items, status);
 				}
 			);
-		} else
+		} else {
 			frappe.confirm(
 				__("Mark {0} {1} as {2}?", [
 					items_to_be_updated.length.toString(),
-					items_to_be_updated.length === 1 ? "item" : "items",
+					items_to_be_updated.length === 1 ? __("goal") : __("goals"),
 					status,
 				]),
 				() => {
 					this.update_status(status, items_to_be_updated, listview);
 					this.trigger_error_dialogs(checked_items, status);
 				}
 			);
+		}
 	},
 
 	trigger_error_dialogs: function (checked_items, status) {
@@ -104,7 +105,7 @@ frappe.listview_settings["Goal"] = {
 				indicator: "orange",
 			});
 
-		const applicable_statuses = applicable_current_statuses(status);
+		const applicable_statuses = get_applicable_current_statuses(status);
 		if (
 			checked_items.some((item) => !applicable_statuses.includes(item.status))
 		)
@@ -143,7 +144,7 @@ frappe.listview_settings["Goal"] = {
 };
 
 // Returns all possible current statuses that can be changed to the new one
-const applicable_current_statuses = (new_status) => {
+const get_applicable_current_statuses = (new_status) => {
 	switch (new_status) {
 		case "Completed":
 			return ["Pending", "In Progress"];