fix: duplicate Additional Salary with Overwrite Salary Structure Amou…

…nt enabled

(cherry picked from commit 15c752f)

hrms/payroll/doctype/additional_salary/additional_salary.py

@@ -5,7 +5,7 @@
 import frappe
 from frappe import _, bold
 from frappe.model.document import Document
-from frappe.utils import comma_and, date_diff, formatdate, getdate
+from frappe.utils import comma_and, date_diff, formatdate, get_link_to_form, getdate
 
 from hrms.hr.utils import validate_active_employee
 
@@ -25,6 +25,7 @@ def validate(self):
 		self.validate_salary_structure()
 		self.validate_recurring_additional_salary_overlap()
 		self.validate_employee_referral()
+		self.validate_duplicate_additional_salary()
 
 		if self.amount < 0:
 			frappe.throw(_("Amount should not be less than zero"))
@@ -111,6 +112,26 @@ def validate_employee_referral(self):
 					).format(frappe.bold("Accepted"))
 				)
 
+	def validate_duplicate_additional_salary(self):
+		if not self.overwrite_salary_structure_amount:
+			return
+		existing_additional_salary = frappe.db.exists(
+			"Additional Salary",
+			{
+				"salary_component": self.salary_component,
+				"payroll_date": self.payroll_date,
+				"overwrite_salary_structure_amount": 1,
+			},
+		)
+		if existing_additional_salary:
+			frappe.throw(
+				_(
+					"Additional Salary of Salary Component {0} with 'Overwrite Salary Structure Amount' enabled already exists for this date. Reference: {1}"
+				).format(
+					self.salary_component, get_link_to_form("Additional Salary", existing_additional_salary)
+				)
+			)
+
 	def update_return_amount_in_employee_advance(self):
 		if self.ref_doctype == "Employee Advance" and self.ref_docname:
 			return_amount = frappe.db.get_value("Employee Advance", self.ref_docname, "return_amount")