Skip to content

Commit

Permalink
fix: journals as invoice throwing validation error (#1185)
Browse files Browse the repository at this point in the history
allocating payment entries against multi-currency journal entries as
invoice with the same exchange rate should not create gain_loss journals
  • Loading branch information
ruthra-kumar authored Dec 15, 2023
1 parent 4abb365 commit 50eaaca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hrms/overrides/employee_payment_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def set_missing_ref_details(
)

for field, value in ref_details.items():
if d.exchange_gain_loss:
if d.exchange_gain_loss is not None:
# for cases where gain/loss is booked into invoice
# exchange_gain_loss is calculated from invoice & populated
# and row.exchange_rate is already set to payment entry's exchange rate
Expand Down

0 comments on commit 50eaaca

Please sign in to comment.