fix: handle salary slip download failure

frappe · Dec 1, 2023 · 8daaba4 · 8daaba4
1 parent c977fec
commit 8daaba4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/frontend/src/views/salary_slip/Detail.vue b/frontend/src/views/salary_slip/Detail.vue
@@ -143,10 +143,11 @@ function downloadPDF() {
 			if (response.ok) {
 				return response.blob()
 			} else {
-				downloadError.value = `Failed to download PDF: ${response.statusText}`
+				downloadError.value = "Failed to download PDF"
 			}
 		})
 		.then((blob) => {
+			if (!blob) return
 			const blobUrl = window.URL.createObjectURL(blob)
 			const link = document.createElement("a")
 			link.href = blobUrl

diff --git a/hrms/api/__init__.py b/hrms/api/__init__.py
@@ -582,7 +582,11 @@ def download_salary_slip(name: str):
 	from frappe.utils.print_format import download_pdf
 
 	default_print_format = frappe.get_meta("Salary Slip").default_print_format or "Standard"
-	download_pdf("Salary Slip", name, format=default_print_format)
+
+	try:
+		download_pdf("Salary Slip", name, format=default_print_format)
+	except Exception:
+		frappe.throw("Failed to download Salary Slip PDF")
 
 	base64content = base64.b64encode(frappe.local.response.filecontent)
 	content_type = frappe.local.response.type