fix: salary slip cancellation with loan repayment (backport #1270) (#…

…1271) (cherry picked from commit 3e36b56) Co-authored-by: Rucha Mahabal <[email protected]>
frappe · Jan 8, 2024 · 98702b0 · 98702b0
1 parent 60c099b
commit 98702b0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py b/hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py
@@ -102,7 +102,7 @@ def make_loan_repayment_entry(doc: "SalarySlip"):
 		"Payroll Settings", "process_payroll_accounting_entry_based_on_employee"
 	)
 
-	for loan in doc.loans:
+	for loan in doc.get("loans", []):
 		if not loan.total_payment:
 			continue
 
@@ -128,7 +128,7 @@ def make_loan_repayment_entry(doc: "SalarySlip"):
 
 @if_lending_app_installed
 def cancel_loan_repayment_entry(doc: "SalarySlip"):
-	for loan in doc.loans:
+	for loan in doc.get("loans", []):
 		if loan.loan_repayment_entry:
 			repayment_entry = frappe.get_doc("Loan Repayment", loan.loan_repayment_entry)
 			repayment_entry.cancel()