test: fix test condition

hrms/hr/doctype/leave_policy_assignment/test_leave_policy_assignment.py

@@ -123,8 +123,11 @@ def test_pro_rated_leave_allocation(self):
 
 	# tests no of leaves for passed months if assignment is based on Leave Period / Joining Date
 	def test_get_leaves_for_passed_months(self):
+		first_day = get_first_day(getdate())
 		annual_allocation = 10
-		leave_type = create_leave_type(leave_type_name="_Test Earned Leave", is_earned_leave=True)
+		leave_type = create_leave_type(
+			leave_type_name="_Test Earned Leave", is_earned_leave=True, allocate_on_day="First Day"
+		)
 		leave_policy = create_leave_policy(leave_type=leave_type, annual_allocation=annual_allocation)
 		leave_policy.submit()
 
@@ -133,23 +136,23 @@ def test_get_leaves_for_passed_months(self):
 			"leave_policy": leave_policy.name,
 		}
 
-		self.employee.date_of_joining = add_months(getdate(), -6)
+		self.employee.date_of_joining = add_months(first_day, -5)
 		self.employee.save()
 		assignment = create_assignment(self.employee.name, frappe._dict(data))
 		new_leaves_allocated = assignment.get_leaves_for_passed_months(
 			annual_allocation, leave_type, self.employee.date_of_joining
 		)
 		self.assertEqual(new_leaves_allocated, 5)
 
-		self.employee.date_of_joining = add_months(getdate(), -36)
+		self.employee.date_of_joining = add_months(first_day, -35)
 		self.employee.save()
 		assignment = create_assignment(self.employee.name, frappe._dict(data))
 		new_leaves_allocated = assignment.get_leaves_for_passed_months(
 			annual_allocation, leave_type, self.employee.date_of_joining
 		)
 		self.assertEqual(new_leaves_allocated, 30)
 
-		leave_period = create_leave_period(add_months(getdate(), -24), getdate())
+		leave_period = create_leave_period(add_months(first_day, -23), first_day)
 		data = {
 			"assignment_based_on": "Leave Period",
 			"leave_policy": leave_policy.name,

hrms/hr/doctype/leave_type/test_leave_type.py

@@ -27,6 +27,7 @@ def create_leave_type(**args):
 			"earning_component": "Leave Encashment",
 			"max_leaves_allowed": args.max_leaves_allowed,
 			"maximum_carry_forwarded_leaves": args.maximum_carry_forwarded_leaves,
+			"allocate_on_day": args.allocate_on_day or "Last Day",
 		}
 	)