feat: Add Select/Unselect All options in Mark Attendance Dialog #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
ruchamahabal
approved these changes
Oct 26, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* feat:Add Unselect all in Mark Attendance Dialog * chore: fix formatting --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit bbe3918)
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* feat:Add Unselect all in Mark Attendance Dialog * chore: fix formatting --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit bbe3918)
ruchamahabal
pushed a commit
that referenced
this pull request
Oct 26, 2023
… (#1006) * feat:Add Unselect all in Mark Attendance Dialog * chore: fix formatting --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit bbe3918) Co-authored-by: Parameshwari Palanisamy <[email protected]>
ruchamahabal
pushed a commit
that referenced
this pull request
Oct 26, 2023
… (#1007) * feat:Add Unselect all in Mark Attendance Dialog * chore: fix formatting --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit bbe3918) Co-authored-by: Parameshwari Palanisamy <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
# [14.15.0](v14.14.0...v14.15.0) (2023-11-01) ### Bug Fixes * close employee loan on write off ([#990](#990)) ([245944d](245944d)) ### Features * Add Select/Unselect All options in Mark Attendance Dialog ([#1005](#1005)) ([#1006](#1006)) ([ee15df8](ee15df8)) * Add sender in payroll setting & HR Setting ([0565dbf](0565dbf))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
# [15.1.0](v15.0.0...v15.1.0) (2023-11-01) ### Bug Fixes * close employee loan on write off ([#991](#991)) ([#1012](#1012)) ([9284a5d](9284a5d)) ### Features * Add employee grade filter in payroll entry ([#960](#960)) ([#1013](#1013)) ([d843c20](d843c20)) * Add Select/Unselect All options in Mark Attendance Dialog ([#1005](#1005)) ([#1007](#1007)) ([95583bc](95583bc)) * Add sender in payroll setting & HR Setting ([147d841](147d841))
ruchamahabal
added a commit
that referenced
this pull request
Nov 30, 2023
…1131) * fix: handle empty states in views * feat: populate leave approvers and allocated leave types * feat: create document * feat: disable save button until all the required fields are filled * chore: bulk format code using prettier * chore: ignore formatting changes in blame * fix: socketio port in config * feat: Edit form/Saved form view - edit form functionality added - show doc ID in header - make fields read-only if emp is viewing some other employee's leave application * feat: set leave application To Date based on From Date * fix: make form header sticky * feat: List view - fetch documents as per tab: team's requests or your own - link to individual records - refactor request panel and list item components for dynamic use * feat: status filter in list view * feat: field level filters with conditions - extract `ListFilterActionSheet` component - implement clear filters - fix filter button style * feat: add expense claim routes and refactor leave routing * feat: Expense Claim summary in dashboard * feat: show recent expenses in Claims dashboard - show claim types, amount, dates in list item - add resource for company wise currency symbols as its needed frequently * feat: show Employee Advance Balance - add routes for Employee Advance views * feat: show claim status along with approval status * feat: Expense Claim list view * refactor(UX): cleaned up Expense Claim form - added tabs and better field grouping - removed unused hidden fields - title, email_id * feat: tabbed view in forms * fix: make save button sticky * fix: allow removing status filter * refactor: cleanup expense claim detail form * feat: expenses child table - table view, modal for adding an entry, empty state, tabs and more * refactor: cleanup expense taxes and charges table form * fix: fix disabled prop type warnings * fix: fields by tab logic * feat: expense taxes & charges child table * fix(Expense Claim): replace unnecessary `add_fetch` calls with doctype config - claim type description, company, employee_name * feat: fetch expense claim type description on type selection * chore: fix advance payments section break * feat: settle claims against advances - auto-set advance allocation amount as per unclaimed amount and grand total * refactor(Expense Claim): extract child tables as separate components * feat: Edit expense items & taxes * feat: fetch expense approver for the current employee * feat: File attachments in Form view * style: fix file uploader style * style: make tabs sticky * style: use better icons * refactor: use autocomplete for filter operator selection * style: fix style on ios (status bar, disabled fields, form view bottom padding) * refactor: Leave Application form cleanup * refactor: clean-up `leave_application.js` - move fetch from configs to doctype json - remove deprecated API usage - fix formatting, replace var -> let * fix: typecast tax rate during expense claim calculations * fix: show recent leaves in Leaves Dashboard for consistency with expense views * fix: shallow copy child table items while editing * fix: recalculate taxes after on adding/editing expenses * fix: avoid accidentally selecting/de-selecting advance cards on editing amount * fix: advance & grand total calculations * feat: apply link field filters * fix(Expense Claim): set default cost center * fix: relative content going above sticky tabs & header on scroll * fix: empty state for advances * feat: set form as read only if session user is not the approver/owner * fix: advance selection while editing expenses * fix: clean-up tabs * feat(Edit doc): delete, upload & fetch existing attachments * feat: show status indicator on saved doc * refactor: move expense claim list config to doctype settings * feat: show colored status badge on saved form * feat: guess status color if doctype states are not configured * fix: order lists by modified desc * fix(form routing): re-route to saved form view on new record insertion * feat: submit & cancel doc * fix: set submitted/cancelled form as read-only * fix(forms): respect perms for submit & cancel * refactor: cleanup employee advance form * feat: Employee Advance form * feat: employee advance list view * fix: add attachment links * feat: unified Request Panel - Leaves + Claims refactor: accept `RequestList` component as prop instead of importing all components * refactor: action sheets for requests * feat: Expense Claim Request Action Sheet * feat: add form link in action sheet * refactor: Approval/Rejection -> Submission/Cancellation flow - don't implicitly submit doc, approve and add a separate action for submission * fix: links for employee advance docs & list view * fix: add quick links * feat(form): add delete & reload menu options * fix: confirm before delete, submit, cancel operations * feat: delete child table row - fix child row add/update button disabling logic * feat: realtime doc list & request updates * fix: modal height exceeding viewport * chore: prod build * fix: add start url to manifest * fix: employee resource unavailable * fix: set collabsible depends on for taxes & advances sections * fix: realtime updates for employee advance * feat: `format_currency` util * feat: Salary Slip dashboard - filter for payroll period - show year to date salary amount - salary slip list * fix: server-sde filter for slips based on payroll period * feat: show Salary Slip details * feat: show earnings & deductions * feat: Download salary slip pdf * refactor: catch Download PDF errors and use fetch for the request * chore(Salary Slip dt): add section labels * fix: section labels not visible in tabbed view * feat: fetch default print format * feat: show loading state while downloading pdf * fix: add custom form button in FormView as slot * fix: Salary Slip Dashboard link * fix: currency fields label & visibility based on doc currency * feat: format read-only currency fields * fix: filter supported fieldtypes on server-side * refactor: realtime updates - unsubscribe before resubscribing for realtime events - unsubscribe on onBeforeUnmount - add realtime events for salary slip - explicitly check user before publishing updates * refactor: employee resource * feat: add Install prompt for PWA * feat: install info prompt for iOS * refactor: move install prompt to a separate component * style: fix popover style * style: fix popover style * revert: "refactor: employee resource" This reverts commit 004bbed. * fix: await employee resource - its used on almost every paroute * fix: make ios install prompt dismissible * fix: install prompt message on non-ios devices * fix: set csrf token in download fetch request * fix: employee resource & ios install prompt placement * feat: add PWA Notification doctype * feat: add pwa mixins for creating approval notifications * feat: Notifications view * feat: notification to employee on approval/rejection * feat: route to ref view and mark notification as read * feat: Mark all as read + unread notifications count * feat: show unread notifications indicator * fix: icon alignment * style: use better icons * feat: add empty state for notifications * refactor: use back button layout instead of baselayout for notifications view * fix: quick links and menu * fix: user ID missing in current user info * chore: update frappe-ui (espresso) * refactor: change button prop appearance -> variant * refactor: fix fonts and font spacing * fix: avatar images * refactor: Dialogs with slots * refactor: Badges colors and style * fix: leave balance cards - font, shadow & colors * style: fix font sizes and dropdown button * fix: font family in ionic css variables * style: increase button padding * fix: vite config * fix: align back icon with title * refactor: replace Input with FormControl wherever possible * refactor: replace Button prop icon-left with prefix template * refactor: action sheet buttons padding * style: change selections/highlighted items from blue to gray - employee advance selection, filter pill selection, applied filters indicator, tab colors * style: change text link color : blue -> gray * style: fix section margins & font size * style: reduce label size and gap bw field & label * style: reduce salary detail table font sizes * style: border radius fixes * style: fix filter style * revert: "refactor: replace Input with FormControl wherever possible" This reverts commit 3c93a8f. * fix: use FormControl wherever required * fix: line spacing for leave balance info * fix: bump up button font size to base * style: fix disabled solid button * style: lighten leave balance chart colors * fix: use md badges and combine expense claim status fields * fix: misc fixes - reqd field indicator not visible - formatted fieldtype Text bg was too dark - convert approve/reject buttons to solid/subtle * fix: checkbox color * style: use outline variant for status badges * style: better empty state for child tables * fix(style): consistent spacing in dashboard sections * fix: disabled input field almost invisible, extremely greyed out * fix: don't show add row button in read only child tables * style: download pdf button disabled style * fix: advances not fetched on new claim - exclude more fields in new leave form * style: fix login button disabled state * fix: double back-swipe animation on ios - on iOS, the back swipe gesture triggers the animation twice: the safari's default back swipe animation & ionic's animation, add config for the same - also disabling menu toggle on backswipe * fix: disable menu on login page * chore: update ionic * fix: install prompt broken during espresso upgrade * fix: add custom `ion-modal` to fix the focus trap issue - ion-modal traps focus inside the modal making controls like autocomplete unusable inside it - add a custom ion-modal that disables backdrop using backdrop-breakpoint=1 and we add a custom backdrop * chore: remove unused ref * style: modal backdrop position and opacity * style: fix install prompt for ios - style broken after espresso upgrade * refactor(PWA): better login - fix the view, add new icon - show error messages - only allow login for a valid employee * feat: show employee, company, contact & salary info on the profile page * fix: increase tap area for back buttons * chore: delete unused file * feat: add better icons for bottom tabs * feat: Bottom Tab instead of Side Menu * refactor: new app header - removed menu toggle & made the header smaller - moved CheckInPanel out of the BaseLayout header * refactor: use back button layout instead of baselayout for profile view * refactor: use sticky IonHeader for BaseLayout * refactor: remove side Menu * refactor: consistent icons & icon styles * fix: tab padding in standalone mode * feat: Add sender in payroll setting & HR Setting * ci: update ci config to consider v15 * chore: update base version for develop * chore: add new frappe hr logo as app icon * chore: update new logo in readme * chore: fix logo in readme * chore: update readme * feat: Add Select/Unselect All options in Mark Attendance Dialog (#1005) * feat:Add Unselect all in Mark Attendance Dialog * chore: fix formatting --------- Co-authored-by: Rucha Mahabal <[email protected]> * fix: close employee loan on write off (#991) * feat: Add employee grade filter in payroll entry (#960) * refactor: use fetch from and `get_sender_email` function * perf: batch and commit auto attendance processing * test(fix): setup shift type for monthly attendance sheet tests * fix: bump employee chunk size * feat(util): add provision to get holidays except weekly offs from holiday list (#1011) * feat: update splash screens, favicon with new logo * chore: set ionic mode to ios - android ionic styles are ugly 🥲 * feat: add safe-area utils to tailwind config * fix: device specific bottom tab padding * chore: upgrade vite * feat: File preview modal for attachments * feat: show File Previews in Request Action Sheets * fix: handle file previews for unsaved docs * chore: Added default permission for HR Manager to submit F&F Statement (#1021) * Added default permission for HR Manager to submit F&F Statement * chore: fix incorrect json * chore: update modified timestamp --------- Co-authored-by: Rucha Mahabal <[email protected]> * fix: revoke object URL before closing the preview * fix: show file upload/deletion errors * fix: only show successful file uploads in attachments + fix deletion before doc save * fix: transpose JPEG images as per EXIF orientation tag on file save * fix: respect image orientation in previews * fix(UX): show loading indicator for ongoing file uploads * refactor: better loading logic + return a promise from the upload function * fix: include private files in proxy config * revert: "ci(temp): use develop branch for frappe and erpnext" This reverts commit fff0eea. * chore: fix linter * refactor(PWA): better routing (#1043) * fix: unread notifications indicator not refreshing * chore: remove frappe-ui readme * chore: remove unused imports * fix: add website route rules for PWA routing * fix(Expense Claim): invalid depends_on expressions & remove stale code * chore: remove unnecessary changes * chore: remove unnecessary changes * chore: remove unnecessary changes --------- Co-authored-by: 14987 <[email protected]> Co-authored-by: Parameshwari Palanisamy <[email protected]> Co-authored-by: Anand Baburajan <[email protected]> Co-authored-by: Varun Rajamane <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
# [15.5.0](v15.4.1...v15.5.0) (2023-12-01) ### Bug Fixes * add reconnection attempts for socket ([2bdad80](2bdad80)) * check for already formatted currency values before formatting ([dbf12fa](dbf12fa)) * consistent currency formatting across views ([a2fd439](a2fd439)) * custom form button visibility ([dd66f87](dd66f87)) * dismiss request modal after applying workflow action ([8f84c97](8f84c97)) * do not disable save button if reqd fields are empty/form is not dirty ([ad7416c](ad7416c)) * double back routing on doc deletion ([b9107fd](b9107fd)) * exclude help section from salary slip view ([9c4fb0c](9c4fb0c)) * form readonly check, allow saving form when dirty ([f55f3b9](f55f3b9)) * format currency in expense dashboard, action sheets ([05634c1](05634c1)) * **formatter:** strip trailing zeros in fraction digits ([fdbb860](fdbb860)) * give employees read access for PWA notification logs ([6bdffb0](6bdffb0)) * go to prev route on doc deletion ([0336b49](0336b49)) * guess status color based on case insensitive status ([1e17a74](1e17a74)) * handle salary slip download failure ([ed8f67c](ed8f67c)) * holiday list visibility & empty state messages ([b9b491a](b9b491a)) * **Leave Application:** allow HR Manager to edit fields at perm level 1 ([5851550](5851550)) * list view loading indicator ([a0799a2](a0799a2)) * make payable account mandatory before submission only ([4462f2f](4462f2f)) * package.json ([d529aaa](d529aaa)) * package.json ([0b3fa4c](0b3fa4c)) * **PWA:** don't show docs in list view while loading ([57813e1](57813e1)) * **PWA:** fetch default expense payable account ([82eb38e](82eb38e)) * **PWA:** Leave Application - do not reset To Date if already set ([c41e3d1](c41e3d1)) * **PWA:** only show title instead of all search fields in link field options ([#1052](#1052)) ([#1134](#1134)) ([aecc294](aecc294)) * **PWA:** reflect correct values in expense table action sheet ([a33e7c5](a33e7c5)) * **PWA:** show link to Employee Advance list even if balance is 0 ([e45e763](e45e763)) * **PWA:** sync sanctioned amt with claimed amt only when claimed amount is edited ([b807cf2](b807cf2)) * realtime updates broken ([b52163b](b52163b)) * realtime updates for employee advance balance & request lists ([aa6bc93](aa6bc93)) * realtime updates in list view ([81f4817](81f4817)) * salary slip detail view route ([0130552](0130552)) * set pointer event none for disabled Autocomplete field ([0b2e2d4](0b2e2d4)) * show the actual session user who approved the application in notifications ([a8516ee](a8516ee)) * show year in holiday date ([8bae372](8bae372)) * translation in msg ([cc07356](cc07356)) * update & fix frappe-ui submodule ([131fb07](131fb07)) ### Features * add missing realtime listeners for dashboards and profile ([c2d8817](c2d8817)) * add Pull to Refresh in list views ([b634683](b634683)) * better workflow controls in request action sheets ([2ac5664](2ac5664)) * **Holiday List:** show day of the week + gray-out completed holidays ([e794a87](e794a87)) * make form read-only based on workflow ([1cc48b7](1cc48b7)) * Progressive Web App - Leaves, Claims, Advances & Salary Slips ([#1131](#1131)) ([13ed24c](13ed24c)), closes [#1005](#1005) * respect 'Allow Self Approval' for workflow actions ([fdcaa82](fdcaa82)) * show request list based on workflow ([89dd763](89dd763)) * show workflow actions in Request Action Sheets ([6f0a01f](6f0a01f)) * show workflow state badge in list & form view ([ec6dc2b](ec6dc2b)) * show workflow state badge in unified request panel ([c4cdbe6](c4cdbe6)) * use computed properties for status & statuscolor + fix workflowDoc eval ([be35875](be35875)) * workflow actions in formview ([8569f92](8569f92)) ### Performance Improvements * fetch link field options only when the field is clicked ([614c0ec](614c0ec)) * infinite scroll for list views ([3cd494e](3cd494e)) * populate Link field options faster ([dc9f0a7](dc9f0a7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Select All and Unselect All Button in Mark Attendance Dialog
Issue: #31743
no-docs