fix: interview reminder settings not respected (backport #1175) #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: interview reminder settings not respected * test: interview reminder settings (cherry picked from commit af8fbf4)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-14-hotfix #1176 +/- ##
=====================================================
+ Coverage 74.20% 74.23% +0.03%
=====================================================
Files 193 193
Lines 10099 10128 +29
=====================================================
+ Hits 7494 7519 +25
- Misses 2605 2609 +4
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
# [14.19.0](v14.18.1...v14.19.0) (2023-12-14) ### Bug Fixes * duplicate additional salary error msg ([e885365](e885365)) * duplicate Additional Salary with Overwrite Salary Structure Amount enabled ([2477baf](2477baf)) * error/warning message ([8a80dc4](8a80dc4)) * including current document while looking for existing Additional Salaries with Overwrite Amount enabled ([8b54d45](8b54d45)) * interview reminder settings not respected ([#1175](#1175)) ([#1176](#1176)) ([e71c1ff](e71c1ff)) * **Leave Application:** Resolved leave type missing for accurate payroll processing ([#1148](#1148)) ([#1171](#1171)) ([335ba95](335ba95)) * remove statistical component from list view display ([d0eebe2](d0eebe2)) * salary structure warning message ([7e8092b](7e8092b)) * salary structure warning message ([d39abf6](d39abf6)) * section name ([c4ab972](c4ab972)) * validation message formatting ([0fdda87](0fdda87)) * warning message ([bc20f17](bc20f17)) ### Features * add Allow Multiple Shift Assignments to HR Settings ([c65637e](c65637e)) * add Amount Based on Formula to list_view ([f62e97d](f62e97d)) * add client-side validation for Amount Based on Salary ([ef8476d](ef8476d)) * add server-side validation for Amount Based on Salary ([b47cea8](b47cea8)) * add validattion for multiple Shift Assignments ([9c8fcee](9c8fcee)) * validate overlapping dates ([03b7598](03b7598))
|
🎉 This PR is included in version 14.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1175 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com