fix: consider previous Leave Applications while enforcing Maximum Consecutive Leaves Allowed (backport #1097) #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…secutive Leaves Allowed (cherry picked from commit 4ae0270)
(cherry picked from commit 085b56e)
(cherry picked from commit 559f0c0)
(cherry picked from commit 0dd0a94)
Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 10eedd4)
Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit c48976c)
(cherry picked from commit eca5d7f)
(cherry picked from commit 32919e6)
- simplify getting dates recursively - avoid extra db call to fetch applications between dates - remove unnecessary list comprehension for generator function (cherry picked from commit 3f63beb)
(cherry picked from commit 4e72879)
(cherry picked from commit 1c5e1cb)
|
🎉 This PR is included in version 14.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1097 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com