fix: Retention Bonus doc cancellation. #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.
…itional_salary' in cancel function
ruchamahabal
changed the title
ruchamahabal
approved these changes
Dec 26, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Fix (retention_bonus): doctype cancellation.
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.
* fix(retention_bonus): convert all of 'self.additional_salary' to 'additional_salary' in cancel function
(cherry picked from commit e64cbde)
mergify bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Fix (retention_bonus): doctype cancellation.
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.
* fix(retention_bonus): convert all of 'self.additional_salary' to 'additional_salary' in cancel function
(cherry picked from commit e64cbde)
ruchamahabal
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Fix (retention_bonus): doctype cancellation.
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.
* fix(retention_bonus): convert all of 'self.additional_salary' to 'additional_salary' in cancel function
(cherry picked from commit e64cbde)
Co-authored-by: Sajad Alimoradi <[email protected]>
ruchamahabal
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Fix (retention_bonus): doctype cancellation.
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.
* fix(retention_bonus): convert all of 'self.additional_salary' to 'additional_salary' in cancel function
(cherry picked from commit e64cbde)
Co-authored-by: Sajad Alimoradi <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
## [14.20.1](v14.20.0...v14.20.1) (2023-12-27) ### Bug Fixes * **Payroll:** accrual entry creation fails if any employee has no earnings (backport [#1214](#1214)) ([#1215](#1215)) ([451c622](451c622)) * Retention Bonus doc cancellation. (backport [#1189](#1189)) ([#1208](#1208)) ([a8a1341](a8a1341))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cancellation, the user encounters the following error:
AttributeError - 'RetentionBonus' object has no attribute 'additional_salary'.