fix: rewrite attendance query in qb & add test for half-day attendance overwritten by leave application #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1205 +/- ##
========================================
Coverage 72.54% 72.54%
========================================
Files 200 200
Lines 10915 10916 +1
========================================
+ Hits 7918 7919 +1
Misses 2997 2997
|
This was referenced Dec 23, 2023
ruchamahabal
added a commit
that referenced
this pull request
Dec 23, 2023
…1205 fix: rewrite attendance query in qb & add test for half-day attendance overwritten by leave application (backport #1205)
ruchamahabal
added a commit
that referenced
this pull request
Dec 23, 2023
…1205 fix: rewrite attendance query in qb & add test for half-day attendance overwritten by leave application (backport #1205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed linter issue with #1147 by converting query to QB
Added test for half-day attendance overwritten by leave application that was fixed here: #1148