Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new doctype for Job offer Term Template (backport #1089) #1237

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 29, 2023

This is an automatic backport of pull request #1089 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* feat: Create new doctype for offer term

* fix: Update job offer

* feat: Add title field in term template

* fix: add default perm for HR Manager, clear table on selecting template

- fix naming, child table fieldnames should be plural

---------

Co-authored-by: Rucha Mahabal <[email protected]>
(cherry picked from commit dfb9712)
@mergify mergify bot requested a review from ruchamahabal as a code owner December 29, 2023 08:16
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ae8e242) 74.30% compared to head (af5a736) 74.27%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-14-hotfix    #1237      +/-   ##
=====================================================
- Coverage              74.30%   74.27%   -0.03%     
=====================================================
  Files                    193      194       +1     
  Lines                  10183    10186       +3     
=====================================================
  Hits                    7566     7566              
- Misses                  2617     2620       +3     
Files Coverage Δ
...job_offer_term_template/job_offer_term_template.py 0.00% <0.00%> (ø)

@ruchamahabal ruchamahabal merged commit 787ab36 into version-14-hotfix Dec 29, 2023
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1089 branch December 29, 2023 08:48
frappe-pr-bot pushed a commit that referenced this pull request Dec 30, 2023
# [14.21.0](v14.20.1...v14.21.0) (2023-12-30)

### Bug Fixes

* [#1226](#1226) local variable "days_to_add" referenced before assignment (backport [#1227](#1227)) ([#1232](#1232)) ([2113d40](2113d40))
* avoid assigning undefined ([a760c38](a760c38))
* Duplicate Overwritten Salary error for other employee ([#1217](#1217)) ([#1218](#1218)) ([6a730f1](6a730f1))
* update job applicant status on interview submit (backport [#892](#892)) ([#1224](#1224)) ([f63b428](f63b428))

### Features

* Add new doctype for Job offer Term Template ([#1089](#1089)) ([#1237](#1237)) ([787ab36](787ab36))
* **Interview:** Add setting for sender in interview & interview feedback reminder emails (backport [#1033](#1033)) ([#1229](#1229)) ([e8d46b3](e8d46b3))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants