Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix installation in setup & flaky tests #1254

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

ruchamahabal
Copy link
Member

No description provided.

@ruchamahabal ruchamahabal changed the title fix: custom field setup ci: fix installation in setup Jan 4, 2024
@ruchamahabal ruchamahabal marked this pull request as ready for review January 4, 2024 05:58
@ruchamahabal ruchamahabal changed the title ci: fix installation in setup ci: fix installation in setup & flaky tests Jan 4, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (dfb9712) 72.48% compared to head (b5e87e4) 72.37%.
Report is 63 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1254      +/-   ##
===========================================
- Coverage    72.48%   72.37%   -0.11%     
===========================================
  Files          201      201              
  Lines        10946    10941       -5     
===========================================
- Hits          7934     7919      -15     
- Misses        3012     3022      +10     
Files Coverage Δ
hrms/hooks.py 100.00% <ø> (ø)
...ms/hr/doctype/interview_detail/interview_detail.py 100.00% <ø> (ø)
...r/doctype/interview_feedback/interview_feedback.py 93.18% <100.00%> (-0.94%) ⬇️
hrms/setup.py 21.37% <ø> (ø)
hrms/hr/doctype/interview_round/interview_round.py 38.88% <0.00%> (ø)
hrms/hr/doctype/job_applicant/job_applicant.py 64.28% <0.00%> (ø)
...roll/doctype/salary_slip/salary_slip_loan_utils.py 27.86% <0.00%> (ø)
hrms/hr/doctype/interview/interview.py 64.41% <88.00%> (+0.44%) ⬆️

... and 3 files with indirect coverage changes

@ruchamahabal ruchamahabal merged commit f4f22d9 into frappe:develop Jan 4, 2024
8 checks passed
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
* ci: fix installation in setup

* fix: flaky test set up

* test: fix flaky tax proof test set up

(cherry picked from commit f4f22d9)
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
* ci: fix installation in setup

* fix: flaky test set up

* test: fix flaky tax proof test set up

(cherry picked from commit f4f22d9)
ruchamahabal added a commit that referenced this pull request Jan 4, 2024
* ci: fix installation in setup

* fix: flaky test set up

* test: fix flaky tax proof test set up

(cherry picked from commit f4f22d9)

Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal added a commit that referenced this pull request Jan 5, 2024
* ci: fix installation in setup

* fix: flaky test set up

* test: fix flaky tax proof test set up

(cherry picked from commit f4f22d9)

Co-authored-by: Rucha Mahabal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants