fix: comp leave request fails on leave period boundary dates #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to replicate:
Fix:
This is because compensatory leave request is applicable 1 day after work end date. In this case its 1/1/2024. So it should find the relevant allocation from that date but instead it finds allocation for work from & to dates (previous leave period) and tries to create a leave ledger entry from 01-01-2024 (applicable date)- 31-12-2023 (fetched allocation end date) (different leave periods).
Since comp off is applicable from the next date, find relevant leave period & allocation from that day onwards. Also improve error message when relevant leave period is missing instead of "There is no leave period in between {0} and {1}". User won't understand what the system is trying to do behind the scenes.