refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1268 +/- ##
===========================================
- Coverage 72.43% 72.41% -0.03%
===========================================
Files 201 201
Lines 10946 10946
===========================================
- Hits 7929 7926 -3
- Misses 3017 3020 +3 |
ruchamahabal
reviewed
Jan 8, 2024
…d Employees Relieving cards
krantheman
force-pushed
the
fix-hr-dashboard
branch
from
be7cc7f
to
711211c
Compare
krantheman
changed the title
ruchamahabal
reviewed
Jan 8, 2024
ruchamahabal
approved these changes
Jan 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…d Employees Relieving cards (#1268) * refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards * chore: update doc owner --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 589e62e)
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…d Employees Relieving cards (#1268) * refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards * chore: update doc owner --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 589e62e)
ruchamahabal
pushed a commit
that referenced
this pull request
Jan 8, 2024
…d Employees Relieving cards (backport #1268) (#1272) * refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards * chore: update doc owner --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 589e62e) Co-authored-by: Akash Tom <[email protected]>
ruchamahabal
pushed a commit
that referenced
this pull request
Jan 8, 2024
…d Employees Relieving cards (backport #1268) (#1273) * refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards * chore: update doc owner --------- Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 589e62e) Co-authored-by: Akash Tom <[email protected]>
krantheman
added a commit
to krantheman/hrms
that referenced
this pull request
Jan 12, 2024
…d Employees Relieving cards (frappe#1268) * refactor(HR Dashboard): show current quarter for Employees Joining and Employees Relieving cards * chore: update doc owner --------- Co-authored-by: Rucha Mahabal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1181
This PR causes the Employees Joining and Employees Relieving cards to be filtered by the current quarter, instead of the next one.
no-docs