fix(Expense Claim): Pass company to properly pick currency for each record #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
approved these changes
Jan 19, 2024
ruchamahabal
changed the title
ruchamahabal
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ecord (backport #1335) (#1337) (cherry picked from commit f7c8f64) Co-authored-by: Suraj Shetty <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
## [15.9.2](v15.9.1...v15.9.2) (2024-01-24) ### Bug Fixes * **Employee Advance:** respect precision for return & paid amount ([2b6f27e](2b6f27e)) * **Expense Claim:** Pass company to properly pick currency for each record (backport [#1335](#1335)) ([#1337](#1337)) ([87a5647](87a5647)) * **Payroll Entry:** permissibility of Queued status doc cancellation (backport [#1298](#1298)) ([#1331](#1331)) ([3c20d42](3c20d42)) * **PWA:** default view for missing profile image (backport [#1343](#1343)) ([#1344](#1344)) ([c001f59](c001f59))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to load company of each record in the list so that currency gets picked up properly in case of multi-currency setup.
Before:
Here Donna raised expense claim in USD but it shows INR in list view cause the system was picking currency from global defaults. (or in some case from
docincur_frmvariable)After:
