Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift type filter in list view of shift assignment (backport #1625) #1628

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 4, 2024

shift type filter in list view of shift assignment


This is an automatic backport of pull request #1625 done by [Mergify](https://mergify.com).

Co-authored-by: Rucha Mahabal <[email protected]>
(cherry picked from commit 438a449)

# Conflicts:
#	hrms/hr/doctype/shift_assignment/shift_assignment.json
@mergify mergify bot requested a review from ruchamahabal as a code owner April 4, 2024 12:22
@mergify mergify bot added the conflicts label Apr 4, 2024
Copy link
Contributor Author

mergify bot commented Apr 4, 2024

Cherry-pick of 438a449 has failed:

On branch mergify/bp/version-14-hotfix/pr-1625
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 438a44938.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/shift_assignment/shift_assignment.json

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruchamahabal
Copy link
Member

Unrelated test failure. Merging

@ruchamahabal ruchamahabal merged commit 32abbc2 into version-14-hotfix Apr 5, 2024
6 of 7 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1625 branch April 5, 2024 14:44
frappe-pr-bot pushed a commit that referenced this pull request Apr 10, 2024
# [14.25.0](v14.24.2...v14.25.0) (2024-04-10)

### Bug Fixes

* employee filter in list view of employee checkin (backport [#1612](#1612)) ([#1615](#1615)) ([b0ed010](b0ed010))
* employee filter in list view of shift assignment (backport [#1624](#1624)) ([#1626](#1626)) ([8ef26a6](8ef26a6))
* shift type filter in list view of shift assignment (backport [#1625](#1625)) ([#1628](#1628)) ([32abbc2](32abbc2))
* use reference name while updating exc rate (backport [#1623](#1623)) ([#1634](#1634)) ([e252e89](e252e89))

### Features

* show holidays and colour code in attendance calendar ([061840b](061840b))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants