Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Shift Assignment): overlapping timings validation (backport #1932) #1983

Merged
merged 4 commits into from
Jul 17, 2024
Merged

fix(Shift Assignment): overlapping timings validation (backport #1932) #1983

merged 4 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. fix(Shift Assignment): timings overlap conditions 

    (cherry picked from commit 981c756)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ae694dc View commit details
    Browse the repository at this point in the history

  2. fix(Shift Assignment): allow shift to start at end_time of another sh… 

    …ift (and vice versa)

(cherry picked from commit 5e880f2)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e821d15 View commit details
    Browse the repository at this point in the history

  3. test: refactor 

    - fix shift overlapping timings tests
- refactor tests to use helper functions and improve readability
- remove redundant test test_multiple_shift_assignments_for_same_day

(cherry picked from commit 155b815)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    af7ea73 View commit details
    Browse the repository at this point in the history

  4. fix(Attendance): overlapping shift attendance 

    (cherry picked from commit 0ea2d12)
    @krantheman @mergify
    krantheman authored and mergify[bot] committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8bef18c View commit details
    Browse the repository at this point in the history