Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use frm instead of this (backport #1990) #1994

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 21, 2024

this refers to the window object that does not have a doctype attribute

On v14, this seems to not be initialized and results in:
Screenshot 2024-07-19 at 5 59 36 PM


This is an automatic backport of pull request #1990 done by [Mergify](https://mergify.com).

(cherry picked from commit 82dd597)
@mergify mergify bot requested a review from ruchamahabal as a code owner July 21, 2024 17:10
@ruchamahabal ruchamahabal merged commit 90721c4 into version-14-hotfix Jul 21, 2024
4 of 5 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1990 branch July 21, 2024 17:32
frappe-pr-bot pushed a commit that referenced this pull request Jul 27, 2024
## [14.29.1](v14.29.0...v14.29.1) (2024-07-27)

### Bug Fixes

* Use `frm` instead of `this` (backport [#1990](#1990)) ([#1994](#1994)) ([90721c4](90721c4))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants