Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort lists before calling itertools.groupby (backport #1997) #2009

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 27, 2024

itertools.groupby returns consecutive groups only when the keys are consecutive. An input of aBaB will create 4 groups, not 2.

https://docs.python.org/3/library/itertools.html#itertools.groupby
https://stackoverflow.com/a/7286


This is an automatic backport of pull request #1997 done by Mergify.

@mergify mergify bot requested a review from ruchamahabal as a code owner July 27, 2024 14:17
@ruchamahabal ruchamahabal merged commit 8cb16a0 into version-15-hotfix Jul 27, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-1997 branch July 27, 2024 14:47
frappe-pr-bot pushed a commit that referenced this pull request Jul 31, 2024
## [15.25.1](v15.25.0...v15.25.1) (2024-07-31)

### Bug Fixes

* Sort lists before calling itertools.groupby (backport [#1997](#1997)) ([#2009](#2009)) ([8cb16a0](8cb16a0))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants